[PATCH] Improve lib/param handling and remove another unused script

Michael Adam obnox at samba.org
Wed Jan 29 14:06:20 MST 2014


On 2014-01-30 at 10:02 +1300, Andrew Bartlett wrote:
> On Wed, 2014-01-29 at 21:46 +0100, Michael Adam wrote:
> > On 2014-01-29 at 20:53 +0100, Michael Adam wrote:
> > > 
> > > Looks good - pushing to autobuild.
> > 
> > Sorry: The patches don't apply.
> > One thing that caught my eye is that your
> > patch uses lpcfg_equal_parameter, whereas
> > current master uses equal_parameter.
> > 
> > Could you point me to more patches that need picking?
> 
> Sorry about that.

No worries.

> Try this set of patches, which includes some of the
> other clean-up patches, including the ones you need for this case.

Will do, thanks.

> > I need an update which of your various patchsets are
> > still missing review.
> 
> I'm tracking that in my param-after-reviews branch.  The big one is the
> param-docs-metadata branch, which fixes up our docs to have enough
> information for the code generator to do its job.
> 
> The other nicely separated set is the patch to use XML entities to have
> correct paths in smb.conf.5.

Alright. I will try to keep reviewing these.

Cheers - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 215 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140129/1d6f0677/attachment.pgp>


More information about the samba-technical mailing list