[PATCH] Rename variables used by loadparm
abartlet at samba.org
Wed Jan 8 16:26:41 MST 2014
On Wed, 2014-01-08 at 08:53 -0500, David Collier-Brown wrote:
> On 01/08/2014 05:13 AM, Volker Lendecke wrote:
> > On Tue, Jan 07, 2014 at 04:34:41PM +1300, Garming Sam wrote:
> >> I've just put all the changes into a repository as the patch was too
> >> big for the list.
> >> git://git.catalyst.net.nz/samba.git rename-param
> > I agree that the names do not follow Samba's variable naming
> > convention, but just doing a sweeping change is questionable
> > at best: It will cause pain for people who have to port back
> > and forth patches for no good functional reason, they don't
> > even clean up convoluted code.
> An orthogonal issue: could we please have a list of the changes in a
> generally useful form, such as sed:
> $sed -e 's/this/that/g' \
> -e '/theother/thing/g' "$@"
> That can be applied to code, documentation and even patch files (;-))
This information (the old and new variable name) is in the title of each
commit, eg 'param: Rename variable used for lp_pathname szPath'. In
this case the variable was szPath and is now pathname.
I hope this helps,
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical