[PATCH] Rename variables used by loadparm

David Collier-Brown davec-b at rogers.com
Wed Jan 8 06:53:53 MST 2014

On 01/08/2014 05:13 AM, Volker Lendecke wrote:
> On Tue, Jan 07, 2014 at 04:34:41PM +1300, Garming Sam wrote:
>> I've just put all the changes into a repository as the patch was too
>> big for the list.
>> git://git.catalyst.net.nz/samba.git rename-param
> I agree that the names do not follow Samba's variable naming
> convention, but just doing a sweeping change is questionable
> at best: It will cause pain for people who have to port back
> and forth patches for no good functional reason, they don't
> even clean up convoluted code.
An orthogonal issue: could we please have a list of the changes in a
generally useful form, such as sed:

$sed -e 's/this/that/g' \
         -e '/theother/thing/g' "$@"

That can be applied to code, documentation and even patch files (;-))


David Collier-Brown,         | Always do right. This will gratify
System Programmer and Author | some people and astonish the rest
davecb at spamcop.net           |                      -- Mark Twain
(416) 223-8968

More information about the samba-technical mailing list