[PATCH] Rename variables used by loadparm

Andrew Bartlett abartlet at samba.org
Wed Jan 8 16:24:14 MST 2014

On Wed, 2014-01-08 at 11:13 +0100, Volker Lendecke wrote:
> On Tue, Jan 07, 2014 at 04:34:41PM +1300, Garming Sam wrote:
> > I've just put all the changes into a repository as the patch was too
> > big for the list.
> > 
> > git://git.catalyst.net.nz/samba.git rename-param
> I agree that the names do not follow Samba's variable naming
> convention, but just doing a sweeping change is questionable
> at best: It will cause pain for people who have to port back
> and forth patches for no good functional reason, they don't
> even clean up convoluted code.

> Can you please explain why you need to rename all the
> parameters?

The future step of auto-generation requires this, as otherwise each of
these variable names would need to be encoded into our XML
documentation, which would increase the risk of errors being introduced
at that step.  While not perfectly consistent, the current _-separated
names generally match the parameter string. 

Finally, while broken up into a multitude of patches, only 4 files are

$ git diff be84f7a04a9288d1e113b1b3fa34e863bc87d1b8..rename-param | diffstat
 lib/param/loadparm.c        |   75 ++--
 lib/param/param_functions.c |  608 +++++++++++++++++++--------------------
 lib/param/param_table.c     |  656 +++++++++++++++++++++---------------------
 source3/param/loadparm.c    |  674 ++++++++++++++++++++++----------------------
 4 files changed, 1006 insertions(+), 1007 deletions(-)

I hope this clarifies things,

Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list