[PATCH] Rename variables used by loadparm
Volker.Lendecke at SerNet.DE
Thu Jan 9 00:28:29 MST 2014
On Thu, Jan 09, 2014 at 12:24:14PM +1300, Andrew Bartlett wrote:
> On Wed, 2014-01-08 at 11:13 +0100, Volker Lendecke wrote:
> > On Tue, Jan 07, 2014 at 04:34:41PM +1300, Garming Sam wrote:
> > > I've just put all the changes into a repository as the patch was too
> > > big for the list.
> > >
> > > git://git.catalyst.net.nz/samba.git rename-param
> > I agree that the names do not follow Samba's variable naming
> > convention, but just doing a sweeping change is questionable
> > at best: It will cause pain for people who have to port back
> > and forth patches for no good functional reason, they don't
> > even clean up convoluted code.
> > Can you please explain why you need to rename all the
> > parameters?
> The future step of auto-generation requires this, as otherwise each of
> these variable names would need to be encoded into our XML
> documentation, which would increase the risk of errors being introduced
> at that step. While not perfectly consistent, the current _-separated
> names generally match the parameter string.
It does. However -- can we discuss how you envision the
parameters to be handled in the future? The current
situation is a mess at best, and before we go too far into
one direction, I would love to see consensus how to do this
in the future. You seem to indicate to generate code from
XML? Wouldn't it be better to generate the XML from code?
This would make XML handling optional for people who *just*
want the code and don't care about manpages.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical