[PATCH] invalid read of deleted memory in

Andreas Schneider asn at samba.org
Fri Feb 28 07:28:21 MST 2014


On Thursday 27 February 2014 12:35:04 Jeremy Allison wrote:
> On Thu, Feb 27, 2014 at 09:13:06AM -0800, Jeremy Allison wrote:
> > Thanks for pointing that out ! It's actually worse
> > than that in that after we call close_file(..., fsp, ...)
> > we shouldn't be touching fsp again.
> > 
> > I'll update your fix and re-submit.
> 
> Noel, what do you think of this ?
> Tidies up the code somewhat.
> 
> Can I get a second Team review ?

You can push it with my review if you change

if (!fsp->print_file) {

to

if (fsp->print_file == NULL) {


:)

	-- andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list