[PATCH] invalid read of deleted memory in

Noel Power nopower at suse.com
Fri Feb 28 02:03:34 MST 2014


On 27/02/14 20:35, Jeremy Allison wrote:
> On Thu, Feb 27, 2014 at 09:13:06AM -0800, Jeremy Allison wrote:
>> Thanks for pointing that out ! It's actually worse
>> than that in that after we call close_file(..., fsp, ...)
>> we shouldn't be touching fsp again.
>>
>> I'll update your fix and re-submit.
> Noel, what do you think of this ?
disappointed I missed the usage in the debug :-)
> Tidies up the code somewhat.
looks much better assuming the now earlier SMB_VFS_STRICT_UNLOCK is ok (
it still protects the write and I guess it isn't needed for what follows )
thanks alot!

Noel


More information about the samba-technical mailing list