[PATCH] invalid read of deleted memory in

Jeremy Allison jra at samba.org
Fri Feb 28 10:32:41 MST 2014


On Fri, Feb 28, 2014 at 03:28:21PM +0100, Andreas Schneider wrote:
> On Thursday 27 February 2014 12:35:04 Jeremy Allison wrote:
> > On Thu, Feb 27, 2014 at 09:13:06AM -0800, Jeremy Allison wrote:
> > > Thanks for pointing that out ! It's actually worse
> > > than that in that after we call close_file(..., fsp, ...)
> > > we shouldn't be touching fsp again.
> > > 
> > > I'll update your fix and re-submit.
> > 
> > Noel, what do you think of this ?
> > Tidies up the code somewhat.
> > 
> > Can I get a second Team review ?
> 
> You can push it with my review if you change
> 
> if (!fsp->print_file) {
> 
> to
> 
> if (fsp->print_file == NULL) {
> 
> 
> :)

Fair cop, I'll make the change :-).

Thanks !

Jeremy.


More information about the samba-technical mailing list