[PATCH] smbclient tarmode rewrite

[Andreas Schneider]

On Friday 14 February 2014 19:35:19 David Disseldorp wrote:
> Hi Andreas,

Hi David,

> Thanks for putting your hand up as second reviewer, and of course a huge
> thanks again to Aurélien for his hard work and effort during GSoC to
> implement (and thoroughly test) this feature - well done!

the style of the code is often not easy to read especially the opposite of a 
bool for the return code. I've added additional patches to improve readability 
there.

I also found is_subpath() pretty scary. I would suggest to simply use 
strstr_m().

 
https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/libarchive


-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org