[PATCH] smbclient tarmode rewrite

Stefan (metze) Metzmacher metze at samba.org
Mon Feb 17 06:47:53 MST 2014

Hi David and Andreas,

>> Thanks for putting your hand up as second reviewer, and of course a huge
>> thanks again to Aurélien for his hard work and effort during GSoC to
>> implement (and thoroughly test) this feature - well done!
> the style of the code is often not easy to read especially the opposite of a 
> bool for the return code. I've added additional patches to improve readability 
> there.
> I also found is_subpath() pretty scary. I would suggest to simply use 
> strstr_m().
> https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/libarchive

As this is a complete rewrite of clitar.c, can you please make sure
that the new code follows less README.Coding?

There're a lot of comments and missing braces, too much whitespaces in
a lot of globals, uses of 'False' instead of false, typedef is used...


More information about the samba-technical mailing list