[PATCH] smbclient tarmode rewrite

David Disseldorp ddiss at suse.de
Fri Feb 14 11:35:19 MST 2014

Hi Andreas,

As discussed, I've pushed Aurélien's reviewed smbclient tarmode changes
to my repo at:

git://git.samba.org/ddiss/samba.git gsoc_clitar_libarchive_upstream

The patch-set comprises of a smbclient tarmode rewrite, which utilises
libarchive for all tar operations, rather than having smbclient roll
its own archives. The tarmode feature can also now be compiled out of
smbclient using the --without-libarchive configure parameter.

Aurélien's (already merged) comprehensive smbclient tarmode test-suite
is enabled alongside the existing test script to provide improved
coverage of all smbclient tar operations.

The original patch set was mostly left alone during review, aside from
a few minor clean-ups/fixes.

Thanks for putting your hand up as second reviewer, and of course a huge
thanks again to Aurélien for his hard work and effort during GSoC to
implement (and thoroughly test) this feature - well done!

Cheers, David

More information about the samba-technical mailing list