Coverity fixes - 2 for Review.
Volker.Lendecke at SerNet.DE
Thu Feb 13 05:46:30 MST 2014
On Thu, Feb 13, 2014 at 07:03:25AM -0500, Ira Cooper wrote:
> On Thu, Feb 13, 2014 at 4:26 AM, Volker Lendecke
> <Volker.Lendecke at sernet.de>wrote:
> > On Wed, Feb 12, 2014 at 09:47:43PM -0500, Ira Cooper wrote:
> > > These are fixes to do_reseed, involving uninitialized memory and a
> > > potential fd leak.
> > >
> > > Thanks for your review,
> > I've been there as well. For the first one -- isn't that
> > asking for something similar as the debian openssl hickup?
> > The second one looks fine to me. Reviewed-by me.
> > Thanks,
> Per our discussion, on IRC.
> I retract both of these patches for now.
> I instead ask the following question: Do we actually ACTIVELY support
> platforms without /dev/urandom. Or even passively?
> Systems that have /dev/urandom: NetBSD, OpenBSD, FreeBSD, Linux, AIX,
> Solaris, illumos and OS X.
> Is there anything I missed on our support list? :) (Irix/Tru64?)
> If not I'd like to lock down /dev/urandom as a requirement, and simplify
> this function. Configure/waf checks would be needed.
+1 for this development. That's the only way to find out
what we loose.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical