Coverity fixes - 2 for Review.

Ira Cooper ira at
Thu Feb 13 05:03:25 MST 2014

On Thu, Feb 13, 2014 at 4:26 AM, Volker Lendecke
<Volker.Lendecke at>wrote:

> On Wed, Feb 12, 2014 at 09:47:43PM -0500, Ira Cooper wrote:
> > These are fixes to do_reseed, involving uninitialized memory and a
> > potential fd leak.
> >
> > Thanks for your review,
> I've been there as well. For the first one -- isn't that
> asking for something similar as the debian openssl hickup?
> The second one looks fine to me. Reviewed-by me.
> Thanks,

Per our discussion, on IRC.

I retract both of these patches for now.

I instead ask the following question: Do we actually ACTIVELY support
platforms without /dev/urandom.  Or even passively?

Systems that have /dev/urandom: NetBSD, OpenBSD, FreeBSD, Linux, AIX,
Solaris, illumos and OS X.

Is there anything I missed on our support list? :)  (Irix/Tru64?)

If not I'd like to lock down /dev/urandom as a requirement, and simplify
this function.  Configure/waf checks would be needed.



More information about the samba-technical mailing list