Coverity fixes - 2 for Review.
jra at samba.org
Thu Feb 13 18:03:28 MST 2014
On Thu, Feb 13, 2014 at 10:26:09AM +0100, Volker Lendecke wrote:
> On Wed, Feb 12, 2014 at 09:47:43PM -0500, Ira Cooper wrote:
> > These are fixes to do_reseed, involving uninitialized memory and a
> > potential fd leak.
> > Thanks for your review,
> I've been there as well. For the first one -- isn't that
> asking for something similar as the debian openssl hickup?
Yes, this buffer is *deliberately* uninitialized
in this code.
I'd +1 a patch adding a comment that makes this
> The second one looks fine to me. Reviewed-by me.
+1 from me also.
Reviewed-by: Jeremy Allison <jra at samba.org>
More information about the samba-technical