[PATCH] Fix the last of the defaults and include a test to check them
garming at catalyst.net.nz
Mon Feb 3 16:42:45 MST 2014
On 03/02/14 19:48, Michael Adam wrote:
> Ok, I need to look more thoroughly, but it seems
> that you kept a lot of the patches introducing the
> "function" metadata - those which I flagged "TODO" in my
> master-param branch. Ideally we would avoid pushing those
> to master, since they would be reverted after the corresponding
> renames anyways ... I will follow up later.
> Cheers - Michael
On top of the branch I just gave you, there's some other conflicting
stuff, but certainly work in progress. Notably an initial attempt to
remove the ctx table and s3_param.h. There's an attempt to perform
substitutions with the lp string functions in the source4 code, so these
changes are making a hit:
Just looking through the remaining meta-data patches, it looks like
they're all simply the ones which add a function name and were
originally marked TODO.
I know it's a bit ugly to revert, but I think the only real alternative
would be to really get those renames right here and now and so I can fix
it all at once.
More information about the samba-technical