[PATCH] Fixing Bug 10720 - error: Unable to convert first SID

[Alexander Bokovoy]

On Mon, Dec 1, 2014 at 9:14 AM, Stefan (metze) Metzmacher
<metze at samba.org> wrote:
> Hi Garming,
>
>> On 26/11/14 16:11, Garming Sam wrote:
>>> The first two patches improves our current testing to correctly
>>> identify the error. They simply build upon the existing wbinfo_sid2xid
>>> tests and are currently in auto-build.
>>>
>>> The other three patches fix the actual issue. The first plumbs a
>>> pointer to struct unixid instead of uid/gid. The second fixes the
>>> return of the id type and the last fixes the ABI - which with
>>> renaming, we can also fix another bug
>>> (https://bugzilla.samba.org/show_bug.cgi?id=10355) where it has naming
>>> conflicts with Brookhaven Protein DataBank libpdb.
>>>
>>
>> The first two patches are now in master, with a minor change to flush
>> the cache for the other tests.
>>
>> The other three only appear to have failed the duplicate symbol check so
>> I've reattached the patches with the build scripts slightly modified so
>> they don't depend on pdb directly.
>
> Would it be possible to support ID_TYPE_BOTH in
> pdb_wbc_sam_id_to_sid() too?
>
> Otherwise it looks good to me.
>
> Regarding the rename to 'samba-passdb' someone from Redhat should comment
> and fix FreeIPA.
I've commented on the other thread and created
https://fedorahosted.org/freeipa/ticket/4778 to track the change on
FreeIPA side.

-- 
/ Alexander Bokovoy