[PATCH] Fixing Bug 10720 - error: Unable to convert first SID

[Andrew Bartlett]

On Mon, 2014-12-01 at 08:14 +0100, Stefan (metze) Metzmacher wrote:
> Hi Garming,
> 
> > On 26/11/14 16:11, Garming Sam wrote:
> >> The first two patches improves our current testing to correctly
> >> identify the error. They simply build upon the existing wbinfo_sid2xid
> >> tests and are currently in auto-build.
> >>
> >> The other three patches fix the actual issue. The first plumbs a
> >> pointer to struct unixid instead of uid/gid. The second fixes the
> >> return of the id type and the last fixes the ABI - which with
> >> renaming, we can also fix another bug
> >> (https://bugzilla.samba.org/show_bug.cgi?id=10355) where it has naming
> >> conflicts with Brookhaven Protein DataBank libpdb.
> >>
> > 
> > The first two patches are now in master, with a minor change to flush
> > the cache for the other tests.
> > 
> > The other three only appear to have failed the duplicate symbol check so
> > I've reattached the patches with the build scripts slightly modified so
> > they don't depend on pdb directly.
> 
> Would it be possible to support ID_TYPE_BOTH in
> pdb_wbc_sam_id_to_sid() too?

This isn't required, you don't use that as an input type, only have it
updated on output, and the underlying wbclient library doesn't support
this with the required wb* calls.  Additionally, I think we should just
drop this module, it only existed for Likewise winbindd replacements,
and they don't work with modern Samba anyway. 

> Otherwise it looks good to me.

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141202/9c16cbae/attachment.pgp>