[PATCH] Fixing Bug 10720 - error: Unable to convert first SID

Stefan (metze) Metzmacher metze at samba.org
Mon Dec 1 00:14:52 MST 2014

Hi Garming,

> On 26/11/14 16:11, Garming Sam wrote:
>> The first two patches improves our current testing to correctly
>> identify the error. They simply build upon the existing wbinfo_sid2xid
>> tests and are currently in auto-build.
>> The other three patches fix the actual issue. The first plumbs a
>> pointer to struct unixid instead of uid/gid. The second fixes the
>> return of the id type and the last fixes the ABI - which with
>> renaming, we can also fix another bug
>> (https://bugzilla.samba.org/show_bug.cgi?id=10355) where it has naming
>> conflicts with Brookhaven Protein DataBank libpdb.
> The first two patches are now in master, with a minor change to flush
> the cache for the other tests.
> The other three only appear to have failed the duplicate symbol check so
> I've reattached the patches with the build scripts slightly modified so
> they don't depend on pdb directly.

Would it be possible to support ID_TYPE_BOTH in
pdb_wbc_sam_id_to_sid() too?

Otherwise it looks good to me.

Regarding the rename to 'samba-passdb' someone from Redhat should comment
and fix FreeIPA.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141201/4cfdb4b8/attachment.pgp>

More information about the samba-technical mailing list