[PATCHES] avoid using custom kpasswd implementation, remove dependency on heimdal rkpty and add tests for "net ads password"

[Andrew Bartlett]

On Fri, 2014-08-29 at 11:49 +0200, Guenther Deschner wrote:
> Hi Andrew,
> 
> On 27/08/14 10:13, Andrew Bartlett wrote:
> > On Wed, 2014-08-27 at 09:15 +0200, Guenther Deschner wrote:
> >> Hi,
> >> 
> >> can someone please review the work in this branch?
> >> 
> >> https://git.samba.org/?p=gd/samba/.git;a=shortlog;h=refs/heads/master-mit-kdc-ok
> >>
> >>
> >> 
> Currently there are new tests for "net ads password" which now no
> >> longer carries its own kpasswd implementation but uses the
> >> interfaces provided by the Kerberos libraries. In addition, we
> >> removed rkpty, an expect like interface to do password change
> >> conversations with our own, slightly modified copy. This is one
> >> of the first steps to get rid of heimdal dependency for testing.
> >> Much more to follow later...
> > 
> > Just one suggestion so far:  Test that the password really changed
> > with a call to smbclient in 'testprogs: test kpasswd via "net ads
> > password"'
> 
> That's funny, we had exactly these smbclient tests in there but
> removed them later as we thought there are not really required and
> make the test slightly slower. But you're right, they make sense. So
> I've re-added them in the appropriate patch. Anything else ?

Minor stuff,  In the first commit can we change it to say 'we do not
build samba4kinit if we use of system MIT krb5', rather than 'fix the
kerberos binaries', or squash with:
'testprogs: allow to run passwords test with MIT and Heimdal kinit.'?

Regardless:  Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Well done, keep up the good work!

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140901/277b0846/attachment.pgp>