[PATCHES] avoid using custom kpasswd implementation, remove dependency on heimdal rkpty and add tests for "net ads password"

Guenther Deschner gd at samba.org
Fri Aug 29 03:49:20 MDT 2014

Hash: SHA1

Hi Andrew,

On 27/08/14 10:13, Andrew Bartlett wrote:
> On Wed, 2014-08-27 at 09:15 +0200, Guenther Deschner wrote:
>> Hi,
>> can someone please review the work in this branch?
>> https://git.samba.org/?p=gd/samba/.git;a=shortlog;h=refs/heads/master-mit-kdc-ok
Currently there are new tests for "net ads password" which now no
>> longer carries its own kpasswd implementation but uses the
>> interfaces provided by the Kerberos libraries. In addition, we
>> removed rkpty, an expect like interface to do password change
>> conversations with our own, slightly modified copy. This is one
>> of the first steps to get rid of heimdal dependency for testing.
>> Much more to follow later...
> Just one suggestion so far:  Test that the password really changed
> with a call to smbclient in 'testprogs: test kpasswd via "net ads
> password"'

That's funny, we had exactly these smbclient tests in there but
removed them later as we thought there are not really required and
make the test slightly slower. But you're right, they make sense. So
I've re-added them in the appropriate patch. Anything else ?


- -- 
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner at redhat.com
Samba Team                              gd at samba.org
Version: GnuPG v1


More information about the samba-technical mailing list