[PATCHES] avoid using custom kpasswd implementation, remove dependency on heimdal rkpty and add tests for "net ads password"

[Andrew Bartlett]

On Wed, 2014-08-27 at 09:15 +0200, Guenther Deschner wrote:
> Hi,
> 
> can someone please review the work in this branch?
> 
> https://git.samba.org/?p=gd/samba/.git;a=shortlog;h=refs/heads/master-mit-kdc-ok
> 
> Currently there are new tests for "net ads password" which now no
> longer carries its own kpasswd implementation but uses the interfaces
> provided by the Kerberos libraries. In addition, we removed rkpty, an
> expect like interface to do password change conversations with our
> own, slightly modified copy. This is one of the first steps to get rid
> of heimdal dependency for testing. Much more to follow later...

Just one suggestion so far:  Test that the password really changed with
a call to smbclient in 'testprogs: test kpasswd via "net ads password"'

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba