change --picky-developer into --non-picky-developer
jra at samba.org
Tue Apr 1 21:38:00 MDT 2014
On Wed, Apr 02, 2014 at 04:30:11PM +1300, Andrew Bartlett wrote:
> On Wed, 2014-03-26 at 14:39 +0100, Stefan (metze) Metzmacher wrote:
> > Hi,
> > > I think we try to avoid them if we can and things like explicit casts
> > > make it easier to understand for people who will get the warnings
> > > and wonder if there's a potential bug.
> > >
> > > I integrated your patch into my branch.
> > >
> > > I've also tested with --bundled-libraries=ALL and allow warning for
> > > popt and zlib. While beeing there I added support for
> > > --bundled-libraries=ALL,!popt and --bundled-libraries=NONE,popt
> > >
> > > https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-picky
> > I've rebased on master.
> > Some more feedback?
> I've just pushed around 100 of the 150 patches to autobuild. I picked
> out the patches that were really easy to review, so I and others can
> focus on the others without the same amount of distraction.
> The remaining patches were just a bit more complex to review, or made
> the code less clear while fixing the error, so I've left those for now.
> I'll provide some concrete suggestions and links when I get a chance.
> That said, tere isn't anything I object to, so if someone wants to take
> on reviewing the remainder, please go right ahead!
Oh thanks Andrew ! That patchset was on my list of
things to get reviewed this week :-). I'd love to
get (and keep) us warning free.
I'll try and get to the rest of them soon.
More information about the samba-technical