[PATCHSET] fix and improve shadow_copy2 [Re: vfs_shadow_copy2] configuration

Michael Adam obnox at samba.org
Fri Oct 4 17:11:34 MDT 2013


Hi Andrew,

On 2013-10-05 at 09:27 +1300, Andrew Bartlett wrote:
> On Fri, 2013-10-04 at 21:21 +0200, Michael Adam wrote:
> > For people who did not follow the previous discussions:
> > 
> > This patchset essentially fixes shadow_copy2 for the
> > "classical" case, i.e. with "shadow:snapdirseverywhere = false".
> >
> > ...
> > 
> > But first to master... :-)
> 
> This looks really good.  I was a bit overwealmed with the number of
> patches at first, but it's just the 'commit for every tiny thing' style,
> and wasn't nearly as difficult when I got into it.
> 
> I've hacked on vfs_shadowcopy2 in the past, so I've reviewed it and it
> is on it's way to autobuild.

It seems to have failed.
Was that a a flakey test?
I just started a private autobuild to verify.

Thanks - Michael

> I particularly look forward to the tests:  We have needed this for quite
> some time now.
> 
> Andrew Bartlett
> 
> -- 
> Andrew Bartlett                                http://samba.org/~abartlet/
> Authentication Developer, Samba Team           http://samba.org
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 215 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131005/904ebea7/attachment.pgp>


More information about the samba-technical mailing list