[PATCHSET] fix and improve shadow_copy2 [Re: vfs_shadow_copy2] configuration

[Thiago Fernandes Crepaldi]

Correct me if I am wrong. Would that patch fix the problem with the
"Restore previous versions" that a Windows 7 client offer ? I applied this
patch to a samba 4.0.9 but it i still not working. For what I recall, that
bug came with Samba 4; Samba 3.6.9 had that in place up and running

Thanks
Thiago


On Fri, Oct 4, 2013 at 8:11 PM, Michael Adam <obnox at samba.org> wrote:

> Hi Andrew,
>
> On 2013-10-05 at 09:27 +1300, Andrew Bartlett wrote:
> > On Fri, 2013-10-04 at 21:21 +0200, Michael Adam wrote:
> > > For people who did not follow the previous discussions:
> > >
> > > This patchset essentially fixes shadow_copy2 for the
> > > "classical" case, i.e. with "shadow:snapdirseverywhere = false".
> > >
> > > ...
> > >
> > > But first to master... :-)
> >
> > This looks really good.  I was a bit overwealmed with the number of
> > patches at first, but it's just the 'commit for every tiny thing' style,
> > and wasn't nearly as difficult when I got into it.
> >
> > I've hacked on vfs_shadowcopy2 in the past, so I've reviewed it and it
> > is on it's way to autobuild.
>
> It seems to have failed.
> Was that a a flakey test?
> I just started a private autobuild to verify.
>
> Thanks - Michael
>
> > I particularly look forward to the tests:  We have needed this for quite
> > some time now.
> >
> > Andrew Bartlett
> >
> > --
> > Andrew Bartlett
> http://samba.org/~abartlet/
> > Authentication Developer, Samba Team           http://samba.org
> >
> >
>



-- 
Thiago Crepaldi