[PATCHSET] fix and improve shadow_copy2 [Re: vfs_shadow_copy2] configuration

Andrew Bartlett abartlet at samba.org
Fri Oct 4 14:27:45 MDT 2013

On Fri, 2013-10-04 at 21:21 +0200, Michael Adam wrote:
> For people who did not follow the previous discussions:
> This patchset essentially fixes shadow_copy2 for the
> "classical" case, i.e. with "shadow:snapdirseverywhere = false".
> The snapdirseverywhere mode was introduced with 4.0. This is
> a mode where snapshot directories can be found in many places
> in the directory tree and not just in one. It was noted only
> with some delay that this introduced regressions with the
> "classical" modes of shadow_copy2.
> This patchset fixes those regressions.
> So I consider this patchset fairly important, and we should
> also file bug reports for 4.0 and 4.1 and bring this patchset
> to these releases.
> But first to master... :-)

This looks really good.  I was a bit overwealmed with the number of
patches at first, but it's just the 'commit for every tiny thing' style,
and wasn't nearly as difficult when I got into it.

I've hacked on vfs_shadowcopy2 in the past, so I've reviewed it and it
is on it's way to autobuild.

I particularly look forward to the tests:  We have needed this for quite
some time now.

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

More information about the samba-technical mailing list