more -fstack-protector!

[Andreas Schneider]

On Wednesday 06 March 2013 12:08:27 Jeremy Allison wrote:
> On Wed, Mar 06, 2013 at 04:16:52PM +0100, Stefan (metze) Metzmacher wrote:
> > Am 06.03.2013 15:22, schrieb Ira Cooper:
> > > This patch adds the ability to:
> > > 
> > > --disable-stack-protector (For those who don't want it.)
> > > --enable-stack-protector-all (For debugging or the paranoid.)
> > > 
> > > Both builds have been tested locally on illumos.  (As far as that they
> > > build.)
> > > 
> > > In the future, please don't default flags like this, without a toggle to
> > > turn them off.
> > 
> > Don't we only want -fstack-protector-all and an option to disable it?
> 
> Yep.
> 
> > I also found -D_FORTIFY_SOURCE=2, do we also want that?

NOTE This requires -O2.

> +1 also. Certainly a good feature to be able to have.


	-- andreas

-- 
Andreas Schneider                   GPG-ID: F33E3FC6
Samba Team                             asn at samba.org
www.samba.org