more -fstack-protector!

Jeremy Allison jra at samba.org
Wed Mar 6 13:08:27 MST 2013


On Wed, Mar 06, 2013 at 04:16:52PM +0100, Stefan (metze) Metzmacher wrote:
> Am 06.03.2013 15:22, schrieb Ira Cooper:
> > This patch adds the ability to:
> > 
> > --disable-stack-protector (For those who don't want it.)
> > --enable-stack-protector-all (For debugging or the paranoid.)
> > 
> > Both builds have been tested locally on illumos.  (As far as that they
> > build.)
> > 
> > In the future, please don't default flags like this, without a toggle to
> > turn them off.
> 
> Don't we only want -fstack-protector-all and an option to disable it?

Yep.

> I also found -D_FORTIFY_SOURCE=2, do we also want that?

+1 also. Certainly a good feature to be able to have.


More information about the samba-technical mailing list