more -fstack-protector!

[Andrew Bartlett]

On Wed, 2013-03-06 at 09:22 -0500, Ira Cooper wrote:
> This patch adds the ability to:
> 
> --disable-stack-protector (For those who don't want it.)
> --enable-stack-protector-all (For debugging or the paranoid.)
> 
> Both builds have been tested locally on illumos.  (As far as that they
> build.)
> 
> In the future, please don't default flags like this, without a toggle to
> turn them off.

On a more meta level:

In Samba, with very, very few fixed-length strings on the stack (die,
pstring, die), where does -fstack-protector help?  Can we get some
diagnostics as to where this is being applied, such that the cost 1%
cost is showing up?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org