review tools (was Re: Code review required for commits - formal Team vote.)

Michael Adam obnox at
Wed Oct 17 13:04:17 MDT 2012

On 2012-10-17 at 17:32 +0200, David Disseldorp wrote:
> On Wed, 17 Oct 2012 11:12:29 -0400
> simo <idra at> wrote:
> > > For an look at patchwork in action, see:
> > >  
> > 
> > Sounds nice and it seem that thanks to the git hook it should work even
> > if it is not used by everybody, meaning we could set it up now and just
> > let it run and let it be used by whoever wants to use it.
> > Is that right ?
> Yes, that's correct.

Sounds very promising.

> > If so I can volunteer to use it and even to set it up, heck even host
> > it.
> Great, I volunteer to use it too. Let me know if I can do anything
> regarding setup.
> Until then I recommend developers get acquainted with git send-email.
> > However I am afraid we may need to create a separate mailing list for
> > reviews/patches in order to avoid drowning other technical discussions ?
> "PATCH" is easy to filter out, but I'm not too concerned either way.

I think in the long run, we will *want* a separat patches ML
anyways, because if we send 6500 patches or even only 2000-3000
patchsets to the samba-technical ML, this might seriously disturb
the visiblity of the actual technical discussions.

I suggest that we start on samba-technical and move to a separate
ML if the disturbance gets too big (if we can use a subject
pattern like [PATCH] for (e.g.) patchwork to pick up).

Cheers - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
URL: <>

More information about the samba-technical mailing list