review tools (was Re: Code review required for commits - formal Team vote.)

Scott Lovenberg scott.lovenberg at gmail.com
Wed Oct 17 11:39:31 MDT 2012


On Wed, Oct 17, 2012 at 9:14 AM, David Disseldorp <ddiss at suse.de> wrote:
>
> I've used patchworks[1] in the past and can recommend it. It is non-
> intrusive such that the ML remains authoritative, and people can ignore
> it if they so choose.
>
> Git + a mailing list should remain the only mandatory review tools IMO.
>
> Cheers, David
>
> 1) http://jk.ozlabs.org/projects/patchwork/


+1.  For the cifs-utils package we've been using it (Jeff Layton set
it up) and it's great
(https://patchwork.kernel.org/project/cifs-client/list/).  I just use
git send-email (well, git format-patch and then git send-email) to the
mailing list and it automagically works.  The patch is shown with
syntax highlighting and you can download it as a mbox or patch file.

--
Peace and Blessings,
-Scott.


More information about the samba-technical mailing list