Code review required for commits - Discuss.

Jeremy Allison jra at
Thu Oct 11 17:07:34 MDT 2012

On Thu, Oct 11, 2012 at 06:54:50PM -0400, Ira Cooper wrote:

> I think Matthieu has a point here, and it is important.  Timely review
> is going to be key.
> And I'm going to amend myself:  If there is code that has sat for 3
> business days, the author/sponsor may push.  A simple flag for review
> will buy time to do the review on complex code.  Use your brain.  But
> if there are no flags... that is consent from "samba-technical".

I'm ok with that. If someone ignores a patch on samba-technical for
3 days without even saying "I want to review this" then it's probably
good to go.

> I'd actually like this, especially in the fileserver areas which seem
> to be causing the sensitivity.  In any case, I'd like this to be
> something we revisit.

Works for me.


More information about the samba-technical mailing list