When was 'session setup' introduced? (propose to change server-side min protocol to match)

[Andrew Bartlett]

On Wed, 2012-05-30 at 08:52 -0700, Jeremy Allison wrote:
> On Wed, May 30, 2012 at 03:57:40PM +1000, Andrew Bartlett wrote:
> > On Wed, 2012-05-30 at 07:50 +0200, Volker Lendecke wrote:
> > > On Wed, May 30, 2012 at 03:46:26PM +1000, Andrew Bartlett wrote:
> > > > On Tue, 2012-05-29 at 21:24 -0500, Christopher R. Hertel wrote:
> > > > > SessionSetupAndX was introduced in LAN Manager v1.0, the first OS/2 version
> > > > > of the protocol.  The Core Protocol does not support SessionSetupAndX.  See:
> > > > > http://msdn.microsoft.com/en-us/library/ee442101
> > > > > 
> > > > > You do realize that this is the first time ever that we will have disabled
> > > > > support for a dialect.  ...and that Windows servers still support this dialect.
> > > > 
> > > > Very interesting.  How does that work?
> > > > 
> > > > In any case, it won't work in Samba, so I propose this.
> > > 
> > > We might need to revive the code and fix bugs, but many
> > > people will be very unhappy about that. The problem is that
> > > there are still disk imagers in use that are dos-based,
> > > fetching the restore images from SMB via the ancient ms-tcp
> > > dos redirector.
> > 
> > When I last used the DOS SMB client (yes, I've used it for imaging too),
> > it was using a modern enough protocol version to be logging in with a
> > username/password.
> > 
> > Do you have a network trace of a failing case?
> 
> I think you are correct here. The last time I used the DOS
> client it did indeed do a sessionsetup call.

Good.  Clearly by the fact that windows doesn't support the protocols it
advertises this doesn't really matter, but should I push my patch?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org