[SCM] Samba Shared Repository - branch master updated

[Andrew Bartlett]

On Wed, 2012-05-30 at 15:26 +0200, Kai Blin wrote:
> On 2012-05-30 15:16, David Disseldorp wrote:
> 
> > See patch attached, it includes Volker's prior text alongside some
> > examples from the kernel CodingStyle doc.
> 
> Thanks, that helps to understand what's meant by the guideline.
> 
> I still disagree with the claim that the fact a macro called
> "NT_STATUS_NOT_OK_RETURN" changes control flow is a surprise, but if the
> rest of the team prefers to spell out the error handling every time,
> then that's what we'll have to do. I'll just look into an editor macro
> instead of a C preprocessor macro to reduce my typing then. :)

On this I certainly agree.  Some of these macros say what they are
doing, and others do not.  NT_STATUS_HAVE_NO_MEMORY doesn't say 'btw, I
return NT_STATUS_NO_MEMORY here' very well.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org