[SCM] Samba Shared Repository - branch master updated

David Disseldorp ddiss at suse.de
Wed May 30 08:15:09 MDT 2012

On Wed, 30 May 2012 15:26:12 +0200
Kai Blin <kai at samba.org> wrote:

> On 2012-05-30 15:16, David Disseldorp wrote:
> > See patch attached, it includes Volker's prior text alongside some
> > examples from the kernel CodingStyle doc.  
> Thanks, that helps to understand what's meant by the guideline.

Thanks for the review :)

> I still disagree with the claim that the fact a macro called
> "NT_STATUS_NOT_OK_RETURN" changes control flow is a surprise,

Yes agreed, but the benefit to readability that the extra ~2 lines of
code added is worth it IMO. Conditional cleanup and gotos make such
macros even worse.

Anyhow I'll hold off pushing the change for now, until there is some
sort of consensus.

Cheers, David

More information about the samba-technical mailing list