serverid patchset ?
obnox at samba.org
Thu May 24 15:23:14 MDT 2012
Jeremy Allison wrote:
> On Thu, May 24, 2012 at 04:45:45PM +0200, Michael Adam wrote:
> > simo wrote:
> > > On Thu, 2012-05-24 at 15:30 +0200, Michael Adam wrote:
> > > >
> > > > except one thing:
> > > > patch #2 does not completely follow the coding guidelines yet:
> > > > the opening brace of the if statement should be in the next line.
> > >
> > > I do not see anything wrong, since when we changed the way we open
> > > braces after if ?
> > Line 224+225 of README.COding:
> > >>> If the beginning statement has to be broken across lines due to length,
> > >>> the beginning brace should be on a line of its own.
> > This goes back to 2007: 1eb031c8d657d3fc5e270acf3326e2cc6a2dc7a6
> Oh, I've never done it this way :-). Guess I'd better think
> about changing...
This is one of the less exercised guidelines anyway.
But I like it very much. For me it makes it much easier
to follow the code logic in more complicated conditions.
But I might be a litte special (if not to say stubborn)
in that respect. ;-)
Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 206 bytes
Desc: not available
More information about the samba-technical