serverid patchset ?
idra at samba.org
Thu May 24 12:35:55 MDT 2012
On Thu, 2012-05-24 at 16:45 +0200, Michael Adam wrote:
> simo wrote:
> > On Thu, 2012-05-24 at 15:30 +0200, Michael Adam wrote:
> > >
> > > except one thing:
> > > patch #2 does not completely follow the coding guidelines yet:
> > > the opening brace of the if statement should be in the next line.
> > I do not see anything wrong, since when we changed the way we open
> > braces after if ?
> Line 224+225 of README.COding:
> >>> If the beginning statement has to be broken across lines due to length,
> >>> the beginning brace should be on a line of its own.
> This goes back to 2007: 1eb031c8d657d3fc5e270acf3326e2cc6a2dc7a6
> Cheers - Michael
Ah I see what you mean,
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>
More information about the samba-technical