serverid patchset ?
jra at samba.org
Thu May 24 12:26:26 MDT 2012
On Thu, May 24, 2012 at 03:15:26PM +0200, Stefan (metze) Metzmacher wrote:
> Am 24.05.2012 14:37, schrieb Michael Adam:
> > Hi Jeremy,
> > In general, the patchset looks very good. Just a few comments,
> > mostly on patch cosmetics:
> > 1. Patch #13 should (or could) be squashed with patch #1.
> > (it only improves the functin added in patch #1)
> > (It could then take a Pair-Programmed-With tag ;)
> > 2. Adding the test (current patch #7)
> > and running the test (curent patch #12) should be
> > the last two patches
> > 3. Adding the new checks should all come before the removal of
> > of the orignal check from parse_share_modes() in patch #5.
> > I.e. patch #5 should be moved to be the last patch before
> > adding the test (i.e the third from the end).
> > 4. The comment and if statement in (current) patch #13 should be
> > reformatted to adhere to our coding style guidelines.
> > 5. The comment in current patch #14 should be reformatted to adhere
> > to coding guidelines.
> > 6. I am not 100% certain about the complete correctnes of the
> > changed file_existed handling in patch #14. I assume you
> > checked it thoroughly...
> I'm currently using the attached patchset in my private branches.
Ok, looks like metze has addressed these issues in his version.
So I'd like to push this version. Everyone OK with that ?
More information about the samba-technical