serverid patchset ?

[Jeremy Allison]

On Thu, May 24, 2012 at 04:45:45PM +0200, Michael Adam wrote:
> simo wrote:
> > On Thu, 2012-05-24 at 15:30 +0200, Michael Adam wrote:
> > > 
> > > except one thing:
> > > patch #2 does not completely follow the coding guidelines yet:
> > > the opening brace of the if statement should be in the next line.
> > 
> > I do not see anything wrong, since when we changed the way we open
> > braces after if ?
> 
> Line 224+225 of README.COding:
> 
> >>> If the beginning statement has to be broken across lines due to length,
> >>> the beginning brace should be on a line of its own.
> 
> This goes back to 2007: 1eb031c8d657d3fc5e270acf3326e2cc6a2dc7a6

Oh, I've never done it this way :-). Guess I'd better think
about changing...