serverid patchset ?

Michael Adam obnox at samba.org
Thu May 24 08:45:45 MDT 2012


simo wrote:
> On Thu, 2012-05-24 at 15:30 +0200, Michael Adam wrote:
> > 
> > except one thing:
> > patch #2 does not completely follow the coding guidelines yet:
> > the opening brace of the if statement should be in the next line.
> 
> I do not see anything wrong, since when we changed the way we open
> braces after if ?

Line 224+225 of README.COding:

>>> If the beginning statement has to be broken across lines due to length,
>>> the beginning brace should be on a line of its own.

This goes back to 2007: 1eb031c8d657d3fc5e270acf3326e2cc6a2dc7a6

Cheers - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120524/1990c084/attachment.pgp>


More information about the samba-technical mailing list