Do any of the compilers we care about not support __func__ or __FUNCTION__?
realrichardsharpe at gmail.com
Thu Jul 19 12:13:01 MDT 2012
On Thu, Jul 19, 2012 at 10:17 AM, David Disseldorp <ddiss at suse.de> wrote:
> On Thu, 19 Jul 2012 09:35:09 -0700
> Richard Sharpe <realrichardsharpe at gmail.com> wrote:
>> I am sick of seeing things like:
>> DEBUG(5,("read_fd_with_timeout: "
>> "blocking read. EOF from client.\n"));
>> return NT_STATUS_END_OF_FILE;
>> where the name of the calling function has been laboriously typed in
>> ... and there have been cases where code has been moved around and the
>> function name not corrected.
> I totally agree. It's redundant information with the __func__ prefix
> added by DEBUG, and is often incorrect.
Actually, David, thanks for explaining what I was really complaining about.
Yeah, since DEBUG puts the __func__prefix in the log, we don't need to
repeat the function name. It just clutters things up.
More information about the samba-technical