samba-tool user add name change to create patch

Theresa Halloran thallora at
Wed Oct 26 12:06:51 MDT 2011

On 10/25/2011 5:20 PM, Andrew Bartlett wrote:
> On Tue, 2011-10-25 at 10:36 -0400, Theresa Halloran wrote:
>> Jeff,
>> I'm new to samba and this environment but when I was looking at
>> samba-tool and evaluating
>> the externals, I noticed that the help on this command already says "add
>> - create a new user".
>> Create makes more sense to me; add sounds like it already exists and
>> adding it to a group,
>> for instance opposite of removemembers is addmembers.
>> I proposed changing add to create to make it consistent with other
>> samba-tool functions; I guess
>> I realized that its not necessarily consistent with the net command.
>> For now I keep add as an alias for ease with transition.
> Let's keep things like 'net' on Samba3 and if someone can check also the
> 'net' on windows where we can.
I'm updating samba-tool, which I believe only effects Samba4.  Samba 3 
is unchanged.
> 'add' and 'create' are close enough that
> I would rather not change it, or if we have changed it, I would like to
> have an alias.
I left add in the code and it still works.  I added a message saying it 
is being deprecated
to help with migration (if its accepted)
> In terms of adding, the user here already exists (they
> are a living, breathing user), they are just being added to the db for
> the first time :-)
We are creating a user account, not an actual user, so create is better! :-)
> Andrew Bartlett

More information about the samba-technical mailing list