samba-tool user add name change to create patch

Andrew Bartlett abartlet at
Tue Oct 25 15:20:09 MDT 2011

On Tue, 2011-10-25 at 10:36 -0400, Theresa Halloran wrote:

> Jeff,
> I'm new to samba and this environment but when I was looking at 
> samba-tool and evaluating
> the externals, I noticed that the help on this command already says "add 
> - create a new user".
> Create makes more sense to me; add sounds like it already exists and 
> adding it to a group,
> for instance opposite of removemembers is addmembers.
> I proposed changing add to create to make it consistent with other 
> samba-tool functions; I guess
> I realized that its not necessarily consistent with the net command.
> For now I keep add as an alias for ease with transition.

Let's keep things like 'net' on Samba3 and if someone can check also the
'net' on windows where we can.  'add' and 'create' are close enough that
I would rather not change it, or if we have changed it, I would like to
have an alias.  In terms of adding, the user here already exists (they
are a living, breathing user), they are just being added to the db for
the first time :-)

Andrew Bartlett

Andrew Bartlett                      
Authentication Developer, Samba Team 

More information about the samba-technical mailing list