Fw: samba-tool: error handling improvements in getopt.py

Jelmer Vernooij jelmer at samba.org
Thu Oct 20 07:41:51 MDT 2011

On 10/17/2011 11:41 PM, Jelmer Vernooij wrote:
>   On 10/17/2011 11:33 PM, Giampaolo Lauria wrote:
> > All,
> >
> > I have put a set of patches on github to improve the way we handle the
> > samba-tool global options.
> >
> > To view the changes, please follow this URL:
> > https://github.com/lauria/Samba4/commits/master
> >
> > Your comments are very much appreciated.
> >
> In general, it's more useful to have patches sent to the list as 
> attachments. It makes it a lot easier to provide feedback (especially 
> for those without a github account), and keeps the rest of the list in 
> the loop.
> Your changes in general seem fine, although I don't see the point in 
> making parse_kerberos_arg a class method. That just makes it harder to 
> reuse elsewhere, or to test individually.
I've merged and pushed all but the last revision. Thanks!



More information about the samba-technical mailing list