Fw: samba-tool: error handling improvements in getopt.py

[Jelmer Vernooij]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 On 10/17/2011 11:33 PM, Giampaolo Lauria wrote:
> All,
>
> I have put a set of patches on github to improve the way we handle the
> samba-tool global options.
>
> To view the changes, please follow this URL:
> https://github.com/lauria/Samba4/commits/master
>
> Your comments are very much appreciated.
>
In general, it's more useful to have patches sent to the list as
attachments. It makes it a lot easier to provide feedback (especially
for those without a github account), and keeps the rest of the list in
the loop.

Your changes in general seem fine, although I don't see the point in
making parse_kerberos_arg a class method. That just makes it harder to
reuse elsewhere, or to test individually.

Cheers,

Jelmer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOnKEAAAoJEACAbyvXKaRXP98P/3j+jIVLUwy3DWWoC7kn9lJM
GQSG/6oEf4gyZgS6jis6hKhdccP/9eS4r0PICGECMGyydR3SzRG4QSZUx9+/yzj5
Nz0fDGJagki5MrOQVmamRlSC89DdkxY25ijm428jw+0VPuv+b5OCVVhvICrL3b9y
QwoyeDEclWArd8j8DSUVy/zjb6ys+yyhli+Sze+bhEnAFeR5kgAyOINSZagr0sAe
pZ5IBnCM3BpxX6UG/JX4HO7jI+chGNwNHvqrxaxeJWdxrrM6ku8mjA4kk6NYwPBI
Hu8nolpvP+W6m60nbTtLG5PxQxHo2Xn9Hbt5DGy4lXliC3HpW8H4S4wTbGBgVyX3
ODAur/NgZI1hxLtLOZDC+1WSmqtfBF5BbK/9DxBEAAqHCYXKVupS3dXoZlakYPLM
JmC0QAXKoQdXcOky//8ZaZIljFzbj3jSENWgizH/ioENnY+QfY0fhoD7OlELNkXd
EaUqg7yuiPOmicvB0xzj57ve45mhrdCIHPfE+A6U2fTi8va+bnIwMfrdA5qTEvCH
f0BhdBT7Bg9+b5OKMwMmH+VRdxfBixHauFbSiOg4q14oz6mXlvASp59gOymX9cSa
VsMi+M8nor/PtNjaNvtO5y5oEJDWlb9nqSL5fxD5pCKoCy6jd3W50YooKadyHNxX
a/IVA1qM0IBkqvBQBEOb
=uPq7
-----END PGP SIGNATURE-----