David Disseldorp ddiss at suse.de
Tue Oct 11 08:33:16 MDT 2011

Thanks for the feedback Metze.

On Tue, 11 Oct 2011 16:11:25 +0200
"Stefan (metze) Metzmacher" <metze at samba.org> wrote:

> > http://git.samba.org/?p=ddiss/samba.git;a=shortlog;h=refs/heads/smb2_copychunk_rb2  
> As said before on IRC I'm not happy with
> http://git.samba.org/?p=ddiss/samba.git;a=commitdiff;h=e3cd5fba80050a2a06bfaa5fdcd01548f8639942
> This should be squashed
> http://git.samba.org/?p=ddiss/samba.git;a=commitdiff;h=d9c671f252d81545a57072d3b19566222eda907f

OK, I'll squash these changes.

> I'd like to split the subfunctions based on the device id of the
> function code:
> Look for smb2_ioctl_device_vals here:
> http://gitweb.samba.org/?p=metze/wireshark/svnmirror.git;a=blob;f=epan/dissectors/packet-smb2.c#l972
> And I think we should move the splitted functions into a new file per
> device.

[MS-SMB2] presents the ioctl CtlCode is an opaque field. I'll have a
hunt around for the documented device id definitions.

Cheers, David

More information about the samba-technical mailing list