[PATCH] smb2 FSCTL_SRV_COPYCHUNK support

[Stefan (metze) Metzmacher]

Am 11.10.2011 16:33, schrieb David Disseldorp:
> Thanks for the feedback Metze.
> 
> On Tue, 11 Oct 2011 16:11:25 +0200
> "Stefan (metze) Metzmacher" <metze at samba.org> wrote:
> 
>>> http://git.samba.org/?p=ddiss/samba.git;a=shortlog;h=refs/heads/smb2_copychunk_rb2  
>>
>> As said before on IRC I'm not happy with
>> http://git.samba.org/?p=ddiss/samba.git;a=commitdiff;h=e3cd5fba80050a2a06bfaa5fdcd01548f8639942
>>
>> This should be squashed
>> http://git.samba.org/?p=ddiss/samba.git;a=commitdiff;h=d9c671f252d81545a57072d3b19566222eda907f
> 
> OK, I'll squash these changes.
> 
>> I'd like to split the subfunctions based on the device id of the
>> function code:
>> Look for smb2_ioctl_device_vals here:
>> http://gitweb.samba.org/?p=metze/wireshark/svnmirror.git;a=blob;f=epan/dissectors/packet-smb2.c#l972
>>
>> And I think we should move the splitted functions into a new file per
>> device.
> 
> [MS-SMB2] presents the ioctl CtlCode is an opaque field. I'll have a
> hunt around for the documented device id definitions.

Sure, for smb2 it's opaque, but not for the filesystem,
see
http://msdn.microsoft.com/en-us/library/windows/hardware/ff543023%28v=vs.85%29.aspx
and
http://msdn.microsoft.com/en-us/library/windows/hardware/ff563821%28v=vs.85%29.aspx

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20111011/fb73b3b0/attachment.pgp>