[PATCH] smb2 FSCTL_SRV_COPYCHUNK support

Stefan (metze) Metzmacher metze at samba.org
Tue Oct 11 08:11:25 MDT 2011


Hi David,

> This set of changes adds support for the FSCTL_SRV_COPYCHUNK server side
> copy operation and the FSCTL_SRV_REQUEST_RESUME_KEY prerequisite.
> Corresponding smbtorture tests are also included (these make up the
> majority of the changes).
> 
> A copy_chunk vfs hook is added for the particular benefit of btrfs backed
> shares, which can harness the awesomeness of BTRFS_IOC_CLONE_RANGE.
> 
> Generic smb2 ioctl error path fixes are still pending (we currently
> incorrectly assume an error response packet on ioctl failure), but for
> now I'd like to get some more eyes over the changes.
> 
> Cheers, David
> --
> 
> http://git.samba.org/?p=ddiss/samba.git;a=shortlog;h=refs/heads/smb2_copychunk_rb2

As said before on IRC I'm not happy with
http://git.samba.org/?p=ddiss/samba.git;a=commitdiff;h=e3cd5fba80050a2a06bfaa5fdcd01548f8639942

This should be squashed
http://git.samba.org/?p=ddiss/samba.git;a=commitdiff;h=d9c671f252d81545a57072d3b19566222eda907f

I'd like to split the subfunctions based on the device id of the
function code:
Look for smb2_ioctl_device_vals here:
http://gitweb.samba.org/?p=metze/wireshark/svnmirror.git;a=blob;f=epan/dissectors/packet-smb2.c#l972

And I think we should move the splitted functions into a new file per
device.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20111011/eca8db4b/attachment.pgp>


More information about the samba-technical mailing list