patches for time limited getncchanges

Matthieu Patou mat at
Thu Nov 17 10:46:23 MST 2011

On 15/11/2011 13:24, Stefan (metze) Metzmacher wrote:
> Hi Matthieu,
>>>> I'm planning to push tomorrow my patches for the isRecycled and for time
>>>> limited getncchanges.
>>> Which is the exact branch?
>> The misc_review.
> I've pushed my version of it, with some fixes and simplifications here:
> One major change is, that we don't check is the recycle bin is enabled,
> it's not needed we just need to check if we have isRecycled in the schema
> and it's missing from the object and msDS-LastKnownRDN is also missing,
> while isDeleted is TRUE.

I think that having a variable called isRecycled to indicate that we 
have the isRecycled attribute is a bit misleading I prefered the 
has_recycled or something similar.

Otherwise I'm ok with this changes.
> We also need some logic in replmd_replicated_apply_merge() not just
> replmd_replicated_apply_add().
Ok I'll do soon.

> Please review my changes, if you're fine with them, we can squash them
> and push to master, one you've added the replmd_replicated_apply_merge()
> logic.
> metze

Matthieu Patou
Samba Team

More information about the samba-technical mailing list