patches for time limited getncchanges

Matthieu Patou mat at
Sun Nov 20 09:00:55 MST 2011

Hello Metze,

On 15/11/2011 13:24, Stefan (metze) Metzmacher wrote:
> Hi Matthieu,
>>>> I'm planning to push tomorrow my patches for the isRecycled and for time
>>>> limited getncchanges.
>>> Which is the exact branch?
>> The misc_review.
> I've pushed my version of it, with some fixes and simplifications here:
> One major change is, that we don't check is the recycle bin is enabled,
> it's not needed we just need to check if we have isRecycled in the schema
> and it's missing from the object and msDS-LastKnownRDN is also missing,
> while isDeleted is TRUE.
> We also need some logic in replmd_replicated_apply_merge() not just
> replmd_replicated_apply_add().
> Please review my changes, if you're fine with them, we can squash them
> and push to master, one you've added the replmd_replicated_apply_merge()
> logic.
> metze
I squashed what was needed and added the needed code for 
replmd_replicated_apply_merge, I pushed all the code in my repo in the 
drs branch:;a=shortlog;h=refs/heads/drs

I think it should be ok, it does the job both (in term of adding the 
isRecycled) for new objects and updated objects.


Matthieu Patou
Samba Team

More information about the samba-technical mailing list