WAF using system versions instead of in tree versions

Jelmer Vernooij jelmer at samba.org
Thu Nov 3 10:09:43 MDT 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/11/11 16:54, Sean Dague wrote:
> I ran into some very bizarre breaks in my test tree yesterday, which
were driving me nuts, until I realized what was going on.
>
> I had run: apt-get build-dep samba4 on Ubuntu 11.10 as a shortcut to
make sure I had all the right header files to build required bits. This
brought in packaged versions of libtalloc-dev, libtevent-dev, and
python-subunit.
>
> Even though WAF correctly identified talloc and tevent as too old in
the configure stage, it still attempted to use them in the link stage.
The issue appears to be that when waf looks for system libraries, it
first checks the pkg-config file. If that exists it also checks the
version. If the pkg-config file exists but is too old it still continues
looking for the library, and then falls back to checking for the library
by simply checking if it exists. This means that it will use the system
library even if it is too old.

We should fix waf to only use the pkg-config file in cases where we can
(e.g. subunit, tevent, talloc, etc) and be strict about the version.

Cheers,

Jelmer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOsrzHAAoJEACAbyvXKaRXwxQP+gLkKRnCmCAmh4ev2RvA9Chu
CbHkR83zohUdiEnTvA7S4EaUpngHG8xumGCI2VTEOFHml42aWWquUKGOMVrwQEyW
Xthhk2ygHDUpnkTD/4rFs8SOSv8odcxBHnf5pF3/9TT91nYRsV16TCJgOBsfeOzd
w4+1paEbxyffgCL5FEfquzHGKot6vWi3atxyXnyQxSzTG1AE2eW8qNhpZzX8OhaC
Kb1huVOUcdbZL2pxmZdLHh8ZJS6wqWEwdq0KEHVgw2PzQ34hbT5TnmcC8mO/tY//
GxrfHXOkG9nJ+cFAy54djmBa7QYeY3iEjKf3924UUB5QKlF+8fvI4Cg+Hw+ibRXQ
kEUoBok/HdD6Eu1z3BF8wSxCQa1Ra0+pICCkx7y+z2jj0NloRKlg44RZ+MLHohl7
wYsRcE/2xQzUZXpU6jAOf3vfFtJGoB25PfGq9tfQDz5FEVMbJ4ZePK92mZd0QW5I
jo6i78qNpfK2QUijZ6y7XXV+rxidQL/xyifKwvi+Qb7Pus63YUVUfM3XbsfPSMwD
IykEXE6GM0zFFmodpzxOI8pD80Y5myEeAaMjjc80AVHXRQNz9hkJHn6Bx8sqTU2s
H2vEknbg0oPxiXgZk0CDlSA00AWqEUELh/yZ02E7rC0GrkwrUC4/hI6P5cWHnOSA
2HYIdP3JogxftW0WtYz/
=juRK
-----END PGP SIGNATURE-----



More information about the samba-technical mailing list